From 95284d6ca687a0ebfa5302fac9b2ab89116af0a9 Mon Sep 17 00:00:00 2001
From: mid-kid <esteve.varela@gmail.com>
Date: Sun, 30 Sep 2018 11:10:01 +0200
Subject: [PATCH] Add tags to define easily-greppable anti-features

---
 satellites/palemoon-decentraleyes.sat |  2 +-
 satellites/palemoon.sat               |  4 +++-
 tags.txt                              | 15 +++++++++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 tags.txt

diff --git a/satellites/palemoon-decentraleyes.sat b/satellites/palemoon-decentraleyes.sat
index 62463a9..477c296 100644
--- a/satellites/palemoon-decentraleyes.sat
+++ b/satellites/palemoon-decentraleyes.sat
@@ -1,4 +1,4 @@
-# TODO: Build jetpack plugin (requires jpm)
+# BIN: Requires jpm to build
 
 name=decentraleyes
 version=1.4.2
diff --git a/satellites/palemoon.sat b/satellites/palemoon.sat
index 6ed5d08..ff86d08 100644
--- a/satellites/palemoon.sat
+++ b/satellites/palemoon.sat
@@ -1,3 +1,5 @@
+# STATIC: Will build static libraries if correct versions aren't found
+
 name=Pale-Moon
 version=28.0.1
 version_autoconf=2.13
@@ -81,7 +83,7 @@ EOF
 # This program is about as picky about compiler flags as it is about the compiler version.
 # Sigh...
 export MOZ_MAKE_FLAGS="$MAKEFLAGS"
-unset CFLAGS CXXFLAGS LDFLAGS MAKEFLAGS
+#unset CFLAGS CXXFLAGS LDFLAGS MAKEFLAGS
 
 # Build
 PATH="$PWD/../autoconf-$version_autoconf/install/bin:$PATH" \
diff --git a/tags.txt b/tags.txt
new file mode 100644
index 0000000..01f62f3
--- /dev/null
+++ b/tags.txt
@@ -0,0 +1,15 @@
+In some build scripts, I might use tags to denote "anti-features" of some of
+the scripts I supply. This doesn't mean they don't work, it's just to indicate
+they contain some things that are undesireable to have to do in a build script.
+
+These tags should be defined at the top of the file with some comment, a la:
+# TAG: Details
+
+This is the list of currently defined tags:
+- STATIC: Contains static libraries
+- PATHS: Uses sed scripts or other hacks to fix hardcoded paths
+- BIN: Includes pre-compiled binaries
+- FLAGS: Doesn't respect one or more *FLAGS variables
+
+At the time of writing, not all of the build scripts include all of the
+correct flags yet. They will be fixed as time goes on.